Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundent json files #606

Merged
merged 12 commits into from
May 26, 2022
Merged

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented May 25, 2022

What this PR does:
remove redundent json files:
image

Which issue(s) this PR fixes:

Fixes #585

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


seeflood added 2 commits May 25, 2022 16:17
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood seeflood requested review from a team May 25, 2022 08:24
zhenjunMa
zhenjunMa previously approved these changes May 25, 2022
Copy link
Contributor

@zhenjunMa zhenjunMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #606 (8d863b5) into main (57d44ac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files         120      120           
  Lines        6377     6377           
=======================================
  Hits         3885     3885           
  Misses       2120     2120           
  Partials      372      372           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d44ac...8d863b5. Read the comment docs.

seeflood added 2 commits May 25, 2022 16:59
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
seeflood added 5 commits May 25, 2022 17:12
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
@seeflood
Copy link
Member Author

Please ignore the codecov error. It's caused by the unstable zookeeper UT:
image

seeflood added 2 commits May 26, 2022 14:00
Signed-off-by: seeflood <zhou.qunli@foxmail.com>
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seeflood seeflood merged commit c1fd81b into mosn:main May 26, 2022
@seeflood seeflood deleted the remove_redundent_json branch May 26, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete redundant json files
4 participants